Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom not found message based on Doctrine Bridge MapEntity #853

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Support custom not found message based on Doctrine Bridge MapEntity #853

merged 1 commit into from
Jan 5, 2025
+18 −1

Conversation

Avariya
Copy link
Contributor

@Avariya Avariya commented Sep 18, 2024 •
edited by GromNaN
Loading

Use custom not found message from ORM bundle. symfony/symfony#51562

@Avariya
Copy link
Contributor Author

Avariya commented Sep 18, 2024 •
edited
Loading

Tricky part is dependency bump, as 6.4 and 7.0 are not supported. Probably it should be new major version of DoctrineMongoDBBundle?

@Avariya Avariya force-pushed the feature/custom-message branch from b1e808c to d18e3eb Compare September 30, 2024 07:56
GromNaN
GromNaN reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sole purpose of this constructor is to change the default $resolver. We should try to add a protected constant DEFAULT_RESOLVER to the parent class to remove this constructor here.

src/Attribute/MapDocument.php Show resolved Hide resolved
@GromNaN GromNaN added the bug label Jan 5, 2025
@GromNaN GromNaN merged commit 08b29d4 into doctrine:5.1.x Jan 5, 2025
3 checks passed
@GromNaN
Copy link
Member

GromNaN commented Jan 5, 2025

Thank you @Avariya

@GromNaN GromNaN added this to the 5.1.2 milestone Jan 5, 2025
@GromNaN GromNaN changed the title [Feature] Support custom not found message based on Doctrine Bridge MapEntity Support custom not found message based on Doctrine Bridge MapEntity Jan 5, 2025
@github-actions github-actions bot mentioned this pull request Jan 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IonBazan IonBazan IonBazan left review comments

@SenseException SenseException SenseException approved these changes

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Avariya @GromNaN @SenseException @IonBazan